-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install-tools #581
Merged
Merged
Fix install-tools #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools.go has been replaced with Makefile.tools in line with agent v3 approach
✅ Deploy Preview for agent-public-docs canceled.
|
github-actions
bot
added
bug
Something isn't working
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
labels
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 66.12% 66.13%
=======================================
Files 118 118
Lines 13461 13461
=======================================
+ Hits 8901 8902 +1
+ Misses 3959 3958 -1
Partials 601 601 ☔ View full report in Codecov by Sentry. |
Dean-Coakley
force-pushed
the
fix-install-tools
branch
from
February 29, 2024 14:48
92a7a46
to
56cd5a9
Compare
Dean-Coakley
force-pushed
the
fix-install-tools
branch
from
February 29, 2024 15:01
56cd5a9
to
088453f
Compare
Dean-Coakley
requested review from
oliveromahony,
dhurley,
craigell,
aphralG,
olli-holmala and
spencerugbo
February 29, 2024 15:16
Dean-Coakley
commented
Feb 29, 2024
olli-holmala
approved these changes
Mar 5, 2024
dhurley
reviewed
Mar 5, 2024
dhurley
approved these changes
Mar 8, 2024
Dean-Coakley
force-pushed
the
fix-install-tools
branch
from
March 11, 2024 12:37
daf5d2e
to
52f4593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
make install-tools
target by pinning dependenciesChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)