Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install-tools #581

Merged
merged 19 commits into from
Mar 11, 2024
Merged

Fix install-tools #581

merged 19 commits into from
Mar 11, 2024

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Feb 28, 2024

Proposed changes

  • Fix make install-tools target by pinning dependencies
  • Pin docker versions for testcontainers
  • Fix sdk codegen makefile targets
  • Update dependencies

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 52f4593
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65eefb174cd60b0008c54a50

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.13%. Comparing base (82c7a23) to head (daf5d2e).
Report is 15 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   66.12%   66.13%           
=======================================
  Files         118      118           
  Lines       13461    13461           
=======================================
+ Hits         8901     8902    +1     
+ Misses       3959     3958    -1     
  Partials      601      601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dean-Coakley Dean-Coakley changed the title WIP: Fix install-tools Fix install-tools Feb 29, 2024
@Dean-Coakley Dean-Coakley self-assigned this Feb 29, 2024
Makefile.tools Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit 30313d9 into main Mar 11, 2024
29 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-install-tools branch March 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants